Skip to content

Change default room version to 11. implements MSC4239 #18680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Change default room version to 11. implements MSC4239 #18680

wants to merge 6 commits into from

Conversation

ShadowRZ
Copy link

@ShadowRZ ShadowRZ commented Jul 14, 2025 •
edited by reivilibre
Loading

Closes: #18530

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct (run the linters)

@ShadowRZ ShadowRZ requested a review from a team as a code owner July 14, 2025 04:59
reivilibre
reivilibre reviewed Jul 15, 2025
View reviewed changes
@reivilibre reivilibre self-requested a review July 15, 2025 10:37
@reivilibre reivilibre enabled auto-merge (squash) July 15, 2025 10:37
@reivilibre
Copy link
Contributor

Part of #18531

@github-actions github-actions bot deployed to PR Documentation Preview July 15, 2025 10:38 Active
@reivilibre reivilibre disabled auto-merge July 15, 2025 10:41
@reivilibre reivilibre enabled auto-merge (squash) July 15, 2025 10:42
@reivilibre reivilibre mentioned this pull request Jul 15, 2025
Open
30 tasks
@github-actions github-actions bot deployed to PR Documentation Preview July 15, 2025 10:42 Active
reivilibre
reivilibre requested changes Jul 15, 2025
View reviewed changes
Copy link
Contributor

@reivilibre reivilibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this breaks a few tests, sadly; those will need sorting out before merging

auto-merge was automatically disabled July 16, 2025 08:03

Head branch was pushed to by a user without write access

ShadowRZ
ShadowRZ commented Jul 16, 2025
View reviewed changes
Copy link
Author

@ShadowRZ ShadowRZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SyTest and Complement also needs to be updated to account for the lack of creator field in m.room.create event in v11 rooms.

@github-actions github-actions bot deployed to PR Documentation Preview July 30, 2025 16:09 Active
@anoadragon453
Copy link
Member

SyTest and Complement also needs to be updated to account for the lack of creator field in m.room.create event in v11 rooms.

@ShadowRZ are you able to create PRs for Sytest and Complement to address that? Or would you prefer someone else take that on?

@ShadowRZ
Copy link
Author

ShadowRZ commented Aug 3, 2025

are you able to create PRs for Sytest and Complement to address that? Or would you prefer someone else take that on?

@anoadragon453 I'd prefer that someone else to take that, as I'm not familar with Perl (for SyTest) / Go (for Complement).

@anoadragon453
Copy link
Member

No worries. I've added it to our internal Maintainer queue 🙂

@MadLittleMods MadLittleMods changed the title Change default room version to 11. implments MSC4239 Change default room version to 11. implements MSC4239 Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reivilibre reivilibre reivilibre requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Room version default does not match the specification.

3 participants

@ShadowRZ @reivilibre @anoadragon453